Skip to content

[Concert] 공연 조회 관련 예외 처리 및 오류 코드 추가#114

Merged
Creamcheesepie merged 2 commits into
mainfrom
feat/#55
Dec 18, 2025
Merged

[Concert] 공연 조회 관련 예외 처리 및 오류 코드 추가#114
Creamcheesepie merged 2 commits into
mainfrom
feat/#55

Conversation

@Creamcheesepie
Copy link
Copy Markdown
Collaborator

@Creamcheesepie Creamcheesepie commented Dec 17, 2025

🔗 관련 이슈

관련된 이슈 번호를 연결해주세요.
Close #이슈번호 를 쓰면 PR merge 시 자동으로 close 됩니다.

🚀 PR 개요

이 PR이 어떤 변경을 포함하고 있는지 간단히 설명해주세요.

  • 공연 조회 관련 예외 처리 및 오류 코드 추가

📌 변경 사항

주요 변경 내용을 체크리스트 형태로 정리해주세요.

  • 기능 추가
  • 버그 수정
  • 리팩터링
  • 문서 업데이트
  • 테스트 추가/수정

🧪 테스트 방법

변경된 내용을 어떻게 테스트했는지 구체적으로 적어주세요.

  1. Postman 통한 테스트

⚠️ 참고 사항

리뷰어가 알아야 할 사항이 있다면 자유롭게 작성해주세요.

  • 추가로 발생할 수 있는 예외 처리 확인해주시면 감사하겠습니다.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

Test Results

1 tests  ±0   1 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2cedc1d. ± Comparison against base commit b8b72c4.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

⭐ JaCoCo Coverage

Line Coverage: 5.39%

📄 Coverage Details

Overall Line Coverage: 5.36% (127 covered / 2369 lines)

Package Summary (lowest first)
Package Line % Covered Missed
com/back/web7_9_codecrete_be/domain/chats/controller 0.00% 0 0
com/back/web7_9_codecrete_be/domain/location/service 0.00% 0 90
com/back/web7_9_codecrete_be/domain/chats/service 0.00% 0 0
com/back/web7_9_codecrete_be/domain/plans/controller 0.00% 0 43
com/back/web7_9_codecrete_be/domain/location/controller 0.00% 0 20
com/back/web7_9_codecrete_be/global/rsData 0.00% 0 11
com/back/web7_9_codecrete_be/domain/location/entity 0.00% 0 15
com/back/web7_9_codecrete_be/global/scheduler 0.00% 0 3
com/back/web7_9_codecrete_be/domain/auth/entity 0.00% 0 0
com/back/web7_9_codecrete_be/domain/auth/service 0.00% 0 121
com/back/web7_9_codecrete_be/domain/plans/service 0.00% 0 278
com/back/web7_9_codecrete_be/global/initData 0.00% 0 30
com/back/web7_9_codecrete_be/domain/users/controller 0.00% 0 20
com/back/web7_9_codecrete_be/domain/email/entity 0.00% 0 6
com/back/web7_9_codecrete_be/domain/users/service 0.00% 0 59
com/back/web7_9_codecrete_be/domain/auth/controller 0.00% 0 24
com/back/web7_9_codecrete_be/domain/artists/controller 0.00% 0 24
com/back/web7_9_codecrete_be/global/aspect 0.00% 0 4
com/back/web7_9_codecrete_be/global/wikidata 0.36% 1 279
com/back/web7_9_codecrete_be/domain/artists/service 0.79% 3 375
com/back/web7_9_codecrete_be/global/musicbrainz 0.99% 1 100
com/back/web7_9_codecrete_be/domain/email/service 1.92% 1 51
com/back/web7_9_codecrete_be/domain/concerts/controller 3.70% 1 26
com/back/web7_9_codecrete_be/domain/concerts/entity 4.29% 3 67
com/back/web7_9_codecrete_be/domain/concerts/service 5.99% 22 345
com/back/web7_9_codecrete_be/domain/artists/entity 11.11% 5 40
com/back/web7_9_codecrete_be/global/rq 12.90% 4 27
com/back/web7_9_codecrete_be/domain/plans/entity 25.00% 21 63
com/back/web7_9_codecrete_be/global/security 26.36% 29 81
com/back/web7_9_codecrete_be/domain/users/entity 29.27% 12 29
com/back/web7_9_codecrete_be/global/storage 33.33% 1 2
com/back/web7_9_codecrete_be/global/spotify 35.71% 5 9
com/back/web7_9_codecrete_be/domain/chats/entity 100.00% 1 0
com/back/web7_9_codecrete_be/global/doc 100.00% 17 0
Lowest Covered Classes (Top 20)
Class Line % Covered Missed
com.back.web7_9_codecrete_be.domain.plans.service.PlanService 0.00% 0 278
com.back.web7_9_codecrete_be.domain.auth.service.AuthService 0.00% 0 76
com.back.web7_9_codecrete_be.domain.artists.service.ArtistService 0.00% 0 65
com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService 0.00% 0 55
com.back.web7_9_codecrete_be.domain.users.service.UserService 0.00% 0 55
com.back.web7_9_codecrete_be.domain.location.service.KakaoLocalService 0.00% 0 47
com.back.web7_9_codecrete_be.domain.plans.controller.PlanController 0.00% 0 43
com.back.web7_9_codecrete_be.domain.concerts.entity.Concert 0.00% 0 40
com.back.web7_9_codecrete_be.global.security.JwtTokenProvider 0.00% 0 37
com.back.web7_9_codecrete_be.domain.plans.entity.Schedule 0.00% 0 34
com.back.web7_9_codecrete_be.domain.artists.entity.Artist 0.00% 0 31
com.back.web7_9_codecrete_be.domain.location.service.LocationService 0.00% 0 30
com.back.web7_9_codecrete_be.global.initData.BaseInitData 0.00% 0 30
com.back.web7_9_codecrete_be.domain.users.entity.User 0.00% 0 29
com.back.web7_9_codecrete_be.domain.auth.service.TokenService 0.00% 0 27
com.back.web7_9_codecrete_be.domain.auth.controller.AuthController 0.00% 0 24
com.back.web7_9_codecrete_be.domain.artists.controller.ArtistsController 0.00% 0 24
com.back.web7_9_codecrete_be.domain.users.controller.UserController 0.00% 0 20
com.back.web7_9_codecrete_be.domain.plans.entity.Plan 0.00% 0 18
com.back.web7_9_codecrete_be.domain.auth.service.KakaoOAuthService 0.00% 0 18
Changed Classes (from this PR)
Source (PR) Class Prefix Line % Covered Missed
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/service/ConcertService.java com.back.web7_9_codecrete_be.domain.concerts.service.ConcertService 0.00% 0 55
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertLikeResponse.java com.back.web7_9_codecrete_be.domain.concerts.dto.concert.ConcertLikeResponse 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertTicketTimeSetRequest.java com.back.web7_9_codecrete_be.domain.concerts.dto.concert.ConcertTicketTimeSetRequest 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertUpdateRequest.java com.back.web7_9_codecrete_be.domain.concerts.dto.concert.ConcertUpdateRequest 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/repository/TicketOfficeRepository.java com.back.web7_9_codecrete_be.domain.concerts.repository.TicketOfficeRepository 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/global/error/code/ConcertErrorCode.java com.back.web7_9_codecrete_be.global.error.code.ConcertErrorCode 0.00% 0 0
src/main/java/com/back/web7_9_codecrete_be/domain/concerts/service/KopisApiService.java com.back.web7_9_codecrete_be.domain.concerts.service.KopisApiService 5.15% 14 258

🔗 Full HTML report: See artifact jacoco-full-html on this run → https://github.com/prgrms-web-devcourse-final-project/WEB7_9_codecrete_BE/actions/runs/20288358968

@Creamcheesepie Creamcheesepie self-assigned this Dec 17, 2025
ys0221
ys0221 reviewed Dec 17, 2025
View reviewed changes
Comment thread ...main/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertUpdateRequest.java
private Long concertId;

@Schema(description = "공연 이름입니다.")
@NotEmpty
Copy link
Copy Markdown
Collaborator

@ys0221 ys0221 Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotEmpty 어노테이션이 문자열 공백(" ")은 허용해주는 걸로 알고있어서 NotBlank 로 선언해주시는게 더 좋을 것 같습니다!!

larama-C
larama-C reviewed Dec 17, 2025
View reviewed changes
Comment thread ...main/java/com/back/web7_9_codecrete_be/domain/concerts/dto/concert/ConcertUpdateRequest.java
private Long placeId;

@Schema(description = "공연 시작 날짜입니다.")
@NotEmpty
Copy link
Copy Markdown
Collaborator

@larama-C larama-C Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotEmpty 어노테이션이 String, List 등 에서만 사용이 가능하고 long, int, localdate에서는 사용 시 런타임 에러가 발생할 수 있다고 합니다!

ys0221
ys0221 approved these changes Dec 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ys0221 ys0221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@Creamcheesepie Creamcheesepie merged commit e559a05 into main Dec 18, 2025
2 checks passed
@Creamcheesepie Creamcheesepie deleted the feat/#55 branch December 18, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larama-C larama-C larama-C approved these changes

@ys0221 ys0221 ys0221 approved these changes

Assignees

@Creamcheesepie Creamcheesepie

Labels

Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Concert] 공연 공용 오류 코드 추가

3 participants

@Creamcheesepie @larama-C @ys0221